Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ROLEARN env variable in noobaa subscription #349

Merged

Conversation

Nikhil-Ladha
Copy link
Member

If ROLEARN env variable is set, then pass on that env variable to noobaa subscription.

Ref: https://issues.redhat.com/browse/RHSTOR-5139

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls change CheckExistingSubscriptions to always update this env variable?

controllers/defaults.go Outdated Show resolved Hide resolved
@Nikhil-Ladha Nikhil-Ladha force-pushed the rolearn-env-var branch 2 times, most recently from 4072a1a to 6b26a12 Compare December 6, 2023 08:30
@Nikhil-Ladha Nikhil-Ladha force-pushed the rolearn-env-var branch 3 times, most recently from f08319e to 9bc9e07 Compare December 6, 2023 10:38
If ROLEARN env variable is set, then pass on that env variable
to noobaa subscription.

Signed-off-by: Nikhil-Ladha <[email protected]>
@Nikhil-Ladha
Copy link
Member Author

Updated the text for getMergedEnv function as discussed, and tested the subscriptions changes with different combinations including updating different subs and other values in config. Everything looks good.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 509016e into red-hat-storage:main Dec 7, 2023
16 checks passed
@Nikhil-Ladha Nikhil-Ladha deleted the rolearn-env-var branch June 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants