csi: add csi-addon sidecar to the rbd provisioner deployment

[rewantsoni]

RBD Provisioner was missing csi-addons sidecar, adding it in this PR

Ref for CSI-Addons Sidecar: container config

[rewantsoni]

/hold
testing is in progress

[rewantsoni]

Tested the deployment of the operator. A new container for csi-addons comes up in the rbd provisioner:

[rewantsoni /Users/rewantsoni/work/scripts/ocs-operator ] oc get po | grep rbdplugin-provisioner
csi-rbdplugin-provisioner-7c6bb6bb5b-rzndz               6/6     Running            0               7m49s
csi-rbdplugin-provisioner-7c6bb6bb5b-xd49j               6/6     Running            0               7m49s

logs for the container:

[rewantsoni /Users/rewantsoni/work/scripts/ocs-operator ] oc logs csi-rbdplugin-provisioner-7c6bb6bb5b-rzndz -c csi-addons
I0222 06:51:31.580376       1 connection.go:154] Connecting to unix:///csi/csi-addons.sock
I0222 06:51:35.458351       1 client.go:79] Probing CSI driver for readiness
I0222 06:51:35.458373       1 connection.go:183] GRPC call: /identity.Identity/Probe
I0222 06:51:35.458380       1 connection.go:184] GRPC request: {}
I0222 06:51:35.460336       1 connection.go:186] GRPC response: {"ready":{"value":true}}
I0222 06:51:35.460442       1 connection.go:187] GRPC error: <nil>

The sidecar container is able to connect CSI Addons Endpoint and we get two new csiaddonsnode for the provisioner:

[rewantsoni /Users/rewantsoni/work/scripts/ocs-operator ] oc get csiaddonsnode | grep provisioner
csi-rbdplugin-provisioner-7c6bb6bb5b-rzndz   openshift-storage-client   106s   openshift-storage.rbd.csi.ceph.com   pod://csi-rbdplugin-provisioner-7c6bb6bb5b-rzndz.openshift-storage-client:9070   ip-10-0-39-233.ap-south-1.compute.internal
csi-rbdplugin-provisioner-7c6bb6bb5b-xd49j   openshift-storage-client   106s   openshift-storage.rbd.csi.ceph.com   pod://csi-rbdplugin-provisioner-7c6bb6bb5b-xd49j.openshift-storage-client:9070   ip-10-0-13-202.ap-south-1.compute.internal

[rewantsoni]

/unhold

[Madhu-1]

Add leader election flags as well https://github.com/rook/rook/blob/d1e3006560489afcfd7e4bc9734ac3a8a8dad2e7/pkg/operator/ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml#L143C12-L154C80

[rewantsoni]

Do we need to add all the leader-election flags?
where can I find the default values for:

            - "--leader-election-lease-duration"
            - "--leader-election-renew-deadline"
            - "--leader-election-retry-period"

[Madhu-1]

the default value exists in other sidecar containers use that one and yes we need to have leader-election when running with provisioner pod

[rewantsoni]

Discussed Offline and updated the leader-election-namespace for the csi-addons sidecar and opened a issue to set the values for the other flags in all the sidecars using this flag

[leelavg]

@rewantsoni just curious, how did this issue surfaced?

[rewantsoni]

@rewantsoni just curious, how did this issue surfaced?

For RDR, two sidecars were missing in the provisioner csi-addons and csi-omap-generator, after a discussion with @Madhu-1 he mentioned that csi-addons should be deployed by default and omap should be deployed when we are enabling DR

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Madhu-1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment