-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Kube Object Sync time before running failover for Discovered Apps #10618
Open
prsurve
wants to merge
7
commits into
red-hat-storage:master
Choose a base branch
from
prsurve:discovered_app_check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsurve
force-pushed
the
discovered_app_check
branch
from
October 7, 2024 11:15
1829ad8
to
937140c
Compare
tests/functional/disaster-recovery/regional-dr/test_failover_and_relocate_discovered_apps.py
Show resolved
Hide resolved
am-agrawa
previously approved these changes
Oct 14, 2024
prsurve
force-pushed
the
discovered_app_check
branch
from
October 17, 2024 13:41
b681c23
to
931f242
Compare
tests/functional/disaster-recovery/regional-dr/test_failover_and_relocate_discovered_apps.py
Show resolved
Hide resolved
prsurve
force-pushed
the
discovered_app_check
branch
2 times, most recently
from
October 22, 2024 14:20
3897407
to
8a3a346
Compare
am-agrawa
previously approved these changes
Nov 7, 2024
…d Apps Signed-off-by: prsurve <[email protected]>
…d Apps Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
prsurve
force-pushed
the
discovered_app_check
branch
from
November 10, 2024 02:42
7188376
to
151f46d
Compare
sidhant-agrawal
approved these changes
Nov 11, 2024
keemano
approved these changes
Nov 12, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keemano, prsurve, sidhant-agrawal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d Apps