Fix test for provider server logs #10541
Conversation
Signed-off-by: Elena Bondarenko <[email protected]>
Signed-off-by: Elena Bondarenko <[email protected]>
Signed-off-by: Elena Bondarenko <[email protected]>
pull-request-size
bot
added
size/S
|
@ebondare it would have been good to have an ocs-ci issue associated with the same. Also, since the logs can keep changing, shall we find another way to check the presence, instead of hardcoding the statement of the logs? |
| f"{cephclient['metadata']['annotations']['ocs.openshift.io.storageclaim']}-" | ||
| f"{cephclient['metadata']['annotations']['ocs.openshift.io.cephusertype']}" | ||
| ) | ||
| except KeyError as err: |
There was a problem hiding this comment.
we need to have assertion on this I think.
If you don’t want to fail test in the middle and collect results of all checks please follow the test_dashboard_validation_ui example: save results of this check along with others to the dict and validate in the end of the test
Signed-off-by: Elena Bondarenko <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebondare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebondare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #10549