Fixes incorrect comparison for test_bucket_used_bytes_metric #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uday Kurundwade <[email protected]>
udaysk23
force-pushed
the
bucket_metric_issue
branch
from
5bebdaf
to
c505744
Compare
ocs-ci
reviewed
Sep 19, 2024
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: ukurundw-37
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_noobaa_prometheus.py::TestNoobaaaPrometheus::test_bucket_used_bytes_metric
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
sagihirshfeld
approved these changes
Sep 23, 2024
keesturam
approved these changes
Sep 23, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keesturam, sagihirshfeld, udaysk23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nagendra202
pushed a commit
to nagendra202/ocs-ci
that referenced
this pull request
Sep 30, 2024
…0536) Signed-off-by: Uday Kurundwade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9489
Response receiving to method:
19:30:27 - MainThread - mcg.test_noobaa_prometheus - INFO - {'status': 'success', 'data': {'resultType': 'vector', 'result': [{'metric': {'__name__': 'NooBaa_bucket_used_bytes', 'bucket_name': 's3-bucket-2617cd552c404b46833d0f2712abd0', 'container': 'core', 'endpoint': 'mgmt', 'instance': '10.131.0.27:8080', 'job': 'noobaa-mgmt', 'namespace': 'openshift-storage', 'pod': 'noobaa-core-0', 'service': 'noobaa-mgmt'}, 'value': [1726754427.034, '0']}]}}The type of
'value': [1726754427.034, '0']isstrand it is getting compared withint 0in below testtests/functional/object/mcg/test_noobaa_prometheus.py::TestNoobaaaPrometheus::test_bucket_used_bytes_metric