[bz:2274165] Test to verify mgr does not crash after enabling rook module #10525
Conversation
Signed-off-by: Parikshith <[email protected]>
parikshithb
added
Test Case
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parikshithb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Parikshith <[email protected]>
Signed-off-by: Parikshith <[email protected]>
Signed-off-by: Parikshith <[email protected]>
| sleep=30, | ||
| func=run_cmd_verify_cli_output, | ||
| cmd="ceph crash ls", | ||
| expected_output_lst={"mgr"}, |
There was a problem hiding this comment.
I think archived crashes will still be listed in the "ceph crash ls" output. The test can fail falsely if there are any existing archived mgr crashes. Instead of checking for a specific mgr, should we check for
"expected_output_lst={"HEALTH_WARN", "daemons have recently crashed"}," and fail the test if we see this message?
There was a problem hiding this comment.
ack, make sense. I changed to use crash ls-new instead of crash ls which suits here. If there was a mgr crash before it would be archived and will not be displayed in crash ls-new o/p
As per ceph docs: Archive a crash report so that it is no longer considered for the RECENT_CRASH health check and does not appear in the crash ls-new output (it will still appear in the crash ls output).
https://docs.ceph.com/en/quincy/mgr/crash/#commands
|
|
||
| """ | ||
| toolbox = pod.get_ceph_tools_pod() | ||
|
|
There was a problem hiding this comment.
you can delete the empty line
| @tier2 | ||
| @brown_squad | ||
| @skipif_external_mode | ||
| @skipif_ocs_version("<4.16") |
There was a problem hiding this comment.
the fix was backported to previous release as well
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cn2
Cluster Configuration: conf/ocsci/live_deployment.yaml
PR Test Suite: tier2
PR Test Path: tests/functional/pod_and_daemons/test_mgr_enable_rook_backend_module.py
Additional Test Params:
OCP VERSION: 4.16-ga
OCS VERSION: 4.16
tested against branch: master
Signed-off-by: Parikshith <[email protected]>
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: pbyregow-cn2
Cluster Configuration: conf/ocsci/live_deployment.yaml
PR Test Suite: tier2
PR Test Path: tests/functional/pod_and_daemons/test_mgr_enable_rook_backend_module.py
Additional Test Params:
OCP VERSION: 4.16-ga
OCS VERSION: 4.16
tested against branch: master
parikshithb
added
Verified
Covers bz: 2274165