Changing deleting procedure for the ceph FS #10148
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivamdurgbuns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: sdurgbun-testcluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: sdurgbun-cluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: sdurgbun-cluster
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
| cmd2 = "ceph fs rm test-ceph-fs --yes-i-really-mean-it" | ||
| ct_pod.exec_cmd_on_pod(cmd2) | ||
| logger.info("Deleting the Cephf Filesystem") | ||
| cephFS_obj.delete() |
There was a problem hiding this comment.
After cephFS_obj.delete(), I think we should add a check to wait for Pod removal before adding it again. Probably that's the leftover Pod being reported.
There was a problem hiding this comment.
@shivamdurgbuns Please verify that the cephfilesystem is actually deleted.
cephFS_obj.ocp.wait_for_delete(
cephFS_obj.name
)
There was a problem hiding this comment.
okay will check it out
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
Signed-off-by: Shivam Durgbuns <[email protected]>
shivamdurgbuns
force-pushed
the
issue/10084
branch
from
986003c
to
4795d73
Compare
pull-request-size
bot
added
size/M
Signed-off-by: Shivam Durgbuns <[email protected]>
pull-request-size
bot
added
size/S
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: sdurgbun-clus417
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_cephfilesystem_creation.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
|
I was talking to @shivamdurgbuns and I want to understand do we even support officially to create more than one cephfilesystem (data pool etc) We can create multiple subvolumegroups within the default cephfilesystem that we get, but we shouldnt be creating more cephfilesystem (unlike blockpools which we can create as many as we want) @jilju @ebenahar request you to add your views In short, ceph osd lspools, should only list 2 pools - data and metadata for the default filesystem ocs-storagecluster-cephfilesystem |
Fixes issue #10084