Syncing latest changes from upstream devel for ceph-csi #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation has `error.Is(err, target)`, so use this as the order of the parameters. Signed-off-by: Niels de Vos <[email protected]>
Prevent re-use of a destroyed connection by setting it to `nil`. This way it is also safe to call `Destroy()` multiple times without causing a panic. Signed-off-by: Niels de Vos <[email protected]>
By labelling the PersistentVolumeClaim with `group: test`, the label selector in the VolumeGroupSnapshot will create a snapshot of an RBD group containing the single volume (or more if there are other volumes in the same namespace with that label). Once the VolumeGroupSnapshot is created, each volume in the group will have a VolumeSnapshot that can be restored. Signed-off-by: Niels de Vos <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch