Syncing latest changes from upstream devel for ceph-csi #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmytro Alieksieiev <[email protected]>
The support for more than 400 snapshots was added at: ceph/ceph#38553 This patch also removes the note regarding deletion of PVCs with snapshots. Closes: ceph#4681 Signed-off-by: Niraj Yadav <[email protected]>
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.18.0 to 0.22.0. - [Commits](golang/oauth2@v0.18.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The secret in the project settings has a typo and is called `SYNK_TOKEN` instead of `SNYK_TOKEN`. Changing the name of the secret does not seem to be trivial; it needs to be deleted and re-created, which requires obtaining a new token, somehow. Adopting the name with the typo in the GitHub Workflow is easier. Signed-off-by: Niels de Vos <[email protected]>
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2), [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) and [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang). Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.30.4 to 1.30.5 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.30.4...service/s3/v1.30.5) Updates `github.com/onsi/ginkgo/v2` from 2.20.0 to 2.20.1 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.0...v2.20.1) Updates `github.com/prometheus/client_golang` from 1.20.1 to 1.20.2 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.1...v1.20.2) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
add a check for CSI as it can be nil for non-csi PV. fixes: ceph#4807 Signed-off-by: Madhu Rajanna <[email protected]>
Many functions that are implemented for the volumeGroup type can be shared with the (coming) volumeGroupSnapshot type. Move these functions into a commonVolumeGroup type, so that volumeGroup and volumeGroupSnapshot can inherit them. Signed-off-by: Niels de Vos <[email protected]>
According to ceph#4467 the cephfs static provisioner expect userID and userKey in the credential secret. Add these values to the helm chart so that they are only included in the templated yaml if the values are non-empty. Signed-off-by: james-choncholas <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch