Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2268158: rebase: update protobuf to 1.33.0 #291

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Apr 10, 2024

updating protobuf to 1.33.0 to fix the CVE [1] [2]

[1] https://pkg.go.dev/vuln/GO-2024-2611

[2] https://bugzilla.redhat.com/show_bug.cgi?id=2268158

Note:- in devel and release-4.16 we are already using 1.33.0

Copy link

openshift-ci bot commented Apr 10, 2024

@Madhu-1: This pull request references Bugzilla bug 2268158, which is invalid:

  • expected the bug to target the "ODF 4.15.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2268158: rebase: update protobuf to 1.33.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1 Madhu-1 requested a review from nixpanic April 10, 2024 12:41
@openshift-ci openshift-ci bot added the approved Its a good idea label Apr 10, 2024
updating protobuf to 1.33.0 to
fix the CVE [1]

[1] https://pkg.go.dev/vuln/GO-2024-2611

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Member Author

Madhu-1 commented Apr 10, 2024

/bugzilla refresh

Copy link

openshift-ci bot commented Apr 10, 2024

@Madhu-1: This pull request references Bugzilla bug 2268158, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.2) matches configured target release for branch (ODF 4.15.2)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 10, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Madhu-1: This pull request references Bugzilla bug 2268158, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.2) matches configured target release for branch (ODF 4.15.2)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

ceph#4479 is the upstream PR, which is a little different, but that looks fine as the version in release-4.15 was a little older.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Apr 11, 2024
Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 12bacf9 into red-hat-storage:release-4.15 Apr 11, 2024
10 checks passed
Copy link

openshift-ci bot commented Apr 11, 2024

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2268158 has been moved to the MODIFIED state.

In response to this:

BUG 2268158: rebase: update protobuf to 1.33.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants