Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment name #358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajaypratap003
Copy link

Description

  • Update deployment name rhoai-operator-controller-manager

  • Fix e2e-tests

https://issues.redhat.com/browse/RHOAIENG-3901

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaypratap003

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link

zdtsw commented Sep 18, 2024

i do not see any requirement saying redhat-ods need to be updated => any reason to change this
the only thing i know is rhods should be replaced by rhoai

@ajaypratap003
Copy link
Author

i do not see any requirement saying redhat-ods need to be updated => any reason to change this the only thing i know is rhods should be replaced by rhoai

I don't have strong opinion. @VaishnaviHire suggested that we should also change deployment name in rhods-operator repo as well.
@VaishnaviHire wdyt ?

@zdtsw
Copy link

zdtsw commented Sep 18, 2024

i do not see any requirement saying redhat-ods need to be updated => any reason to change this the only thing i know is rhods should be replaced by rhoai

I don't have strong opinion. @VaishnaviHire suggested that we should also change deployment name in rhods-operator repo as well. @VaishnaviHire wdyt ?

ok, if this is to match nightly i am fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants