Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-12537: Improve Searchability of RHOAI in Operator Catalog #356

Merged

Conversation

mlassak
Copy link

@mlassak mlassak commented Sep 17, 2024

Description

Added missing RHOAI-related keywords to the RHOAI operator bundle's CSV, to improve searchability of RHOAI operator

JIRA reference: RHOAIENG-12537

How Has This Been Tested?

Manually tested on dev OpenShift cluster in the OperatorHub UI

Testing steps:

  1. build and push bundle image
  2. build and push index/catalog image
  3. deploy a CatalogSource that references the index/catalog image into openshift-marketplace namespace
  4. search for RHOAI operator in OperatorHub UI using the added keywords

Screenshot or short clip

image
image

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
Copy link

zdtsw commented Sep 17, 2024

tbh, i am a bit surprised.
is the test done on a 4.16 cluster? because i remember we were trying the same thing in the past on an old OCP, might be 4.12 -ish but did not work with purely update keywords to get RHOAI (RHODS at that time) work

@mlassak
Copy link
Author

mlassak commented Sep 17, 2024

tbh, i am a bit surprised. is the test done on a 4.16 cluster? because i remember we were trying the same thing in the past on an old OCP, might be 4.12 -ish but did not work with purely update keywords to get RHOAI (RHODS at that time) work

yes, testing was done on a 4.16 cluster

@zdtsw
Copy link

zdtsw commented Sep 20, 2024

/test rhods-operator-e2e

Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We will need to update midstream with these changes as well

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac, mlassak, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e6de652 into red-hat-data-services:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants