webhook: refactor with switch and helpers (#1076) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prepare to implement deletion check. - Use switch to select supported requests, easier to add Delete then. - Remove misleading messages for the allowed case, the last one only is in use. - Use helpers to count and to compare, there will be the same logic for deletion check. - Tune allowed message. - Use go style case with several variants instead of C-style. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 97e29c9)
ykaliuta
force-pushed
the
rhoai-webhook-refactor
branch
from
cd1ac3f
to
961061f
Compare
|
included in #357? do we still want this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the upstream patch
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria