Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit tests for kubeflow training and kserve alerts #352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jackdelahunt
Copy link

@jackdelahunt jackdelahunt commented Sep 16, 2024

Description

This pr adds support for unit tests for the kserve and kubeflow alerts

How Has This Been Tested?

cd tests/prometheus_unit_tests

# Use yq to pull the alert definitions out of the larger config file
yq '.data."rhods-dashboard-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > dashboard_alerts.yaml && yq '.data."model-mesh-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > model_mesh_alerts.yaml && yq '.data."trustyai-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > trustyai_alerts.yaml && yq '.data."odh-model-controller-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > model_controller_alerts.yaml && yq '.data."workbenches-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > workbenches_alerts.yaml && yq '.data."data-science-pipelines-operator-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > data_science_pipelines_operator_alerts.yaml && yq '.data."kserve-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > kserve_alerts.yaml && yq '.data."trainingoperator-alerting.rules"' ../../config/monitoring/prometheus/apps/prometheus-configs.yaml > training_operator_alerts.yaml

# Run the unit tests
promtool test rules *_unit_tests.yaml

Screenshot or short clip

image

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackdelahunt
Once this PR has been reviewed and has the lgtm label, please assign biswassri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 16, 2024

Hi @jackdelahunt. Thanks for your PR.

I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VaishnaviHire
Copy link

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants