Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workbench deployment + change path for its manifests in build #343

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Sep 10, 2024

Description

ref: https://issues.redhat.com/browse/RHOAIENG-12786

How Has This Been Tested?

  • local build with PR: quay.io/wenzhou/rhoai-operator-catalog:v2.14.910-0
    result similar to ODH PR
  • mock build with passing env for workbenchimages: quay.io/wenzhou/rhoai-operator-catalog:v2.14.910-2
    enable workbench
    2 CM created + imagestream created: quay.io/modh/.... are used
    see both notebook-controller and kf-notebook-controller have issue to pull image which passed from Operator => expected, params.env is working to use these images instead of one from quay.io

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
Copy link
Author

zdtsw commented Sep 10, 2024

/test rhods-operator-e2e

@VaishnaviHire
Copy link

Is this required for 2.13 release branch?

@VaishnaviHire
Copy link

/test rhods-operator-e2e

@zdtsw
Copy link
Author

zdtsw commented Sep 11, 2024

Is this required for 2.13 release branch?

no, this is the original PR which is targeting for "main"
with both fix for jira 12409 and some misaligement of workbench in ODH and RHOAI.
i created a new jira to follow this https://issues.redhat.com/browse/RHOAIENG-12732

- sync to changes in ODH on workbench
- also uplift branch to 2.13 to get new manifests

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw
Copy link
Author

zdtsw commented Sep 12, 2024

/test rhods-operator-e2e

Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit d44fde9 into red-hat-data-services:main Sep 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants