-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workbench deployment + change path for its manifests in build #343
Conversation
/test rhods-operator-e2e |
Is this required for 2.13 release branch? |
/test rhods-operator-e2e |
no, this is the original PR which is targeting for "main" |
- sync to changes in ODH on workbench - also uplift branch to 2.13 to get new manifests Signed-off-by: Wen Zhou <[email protected]>
/test rhods-operator-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
ref: https://issues.redhat.com/browse/RHOAIENG-12786
How Has This Been Tested?
result similar to ODH PR
enable workbench
2 CM created + imagestream created: quay.io/modh/.... are used
see both notebook-controller and kf-notebook-controller have issue to pull image which passed from Operator => expected, params.env is working to use these images instead of one from quay.io
Screenshot or short clip
Merge criteria