Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] fix: dashboard image not get set in downstream due to devFlags conf (#1224) #342

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Sep 6, 2024

Description

  • if DSC CR has old format with empty devFlag:{}, it can cause downstream image not replace but run with quay.io one

Signed-off-by: Wen Zhou [email protected]
(cherry picked from commit 1dbe269)

https://issues.redhat.com/browse/RHOAIENG-12300

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…opendatahub-io#1224)

- if DSC CR has old format with empty devFlag:{}, it can cause downstream image not replace but run with quay.io one

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 1dbe269)
@VaishnaviHire
Copy link

/lgtm

Copy link

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8b63c37 into red-hat-data-services:rhoai-2.13 Sep 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants