feat(modelserving): skip reconcile on deployment resources #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <[email protected]>
|
we will need this to back port to ODH and sync to RHOAI main, regardless we want it to be in 2.9.1 or not |
|
LGTM |
3 tasks
|
backport to ODH opendatahub-io#1002 |
VaishnaviHire
merged commit 9f2b329
into
red-hat-data-services:rhoai-2.9
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://issues.redhat.com/browse/RHOAIENG-6989
it is similar request but on model servering.
we no need to opt on odh-model-controller since it uses the same component name either by kserve or model servering.
As: if we only enabled Kserve but not modelmesh in 2.9.0, we can config odh-model-controller resource already.
local build quay.io/wenzhou/rhods-operator-catalog:v2.9.6989
manually updated deployment of
modelmesh-controller to
odh-model-controller to
pods get recreated and stay the same value , not reverted back to original one