[sync]: remove leader election for operator (#1000) #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since our design is for only one instance of pod, there is no need to enable leader-election - in a shady env. this can cause error Signed-off-by: Wen Zhou <[email protected]>
|
/hold Revisit removal of leader election |
|
opendatahub-io#1008 has been cherry-picked to "main", should we get this one merged? |
|
@zdtsw: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
close this, we have re-anbled leader election in upstream, this PR is invalid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opendatahub-io#1000
ref https://issues.redhat.com/browse/RHOAIENG-6798
and we need https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/2036 in after this PR is merged