Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(CSV): annontation for features #238

Merged
merged 1 commit into from
Apr 14, 2024
Merged

update(CSV): annontation for features #238

merged 1 commit into from
Apr 14, 2024

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Apr 9, 2024 •
edited
Loading

to follow up discussion https://redhat-internal.slack.com/archives/C05NXTEHLGY/p1712673912685679?thread_ts=1712136020.868139&cid=C05NXTEHLGY

ref https://issues.redhat.com/browse/RHOAIENG-5088

this PR has 2 parts:

  • when we added annotation it was not backport to main branch
  • set to false, (see jira issue)

@zdtsw zdtsw added the rhoai-2.9 label Apr 9, 2024
@zdtsw zdtsw requested a review from VaishnaviHire April 9, 2024 15:03
@zdtsw zdtsw added main and removed rhoai-2.9 labels Apr 9, 2024
VaishnaviHire
VaishnaviHire approved these changes Apr 14, 2024
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaishnaviHire VaishnaviHire merged commit b0ecd61 into red-hat-data-services:main Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @VaishnaviHire