[sync]: from ODH to RHOAI #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after introducing validating webhook these are not needed anymore.
This functionality has not been aligned with the functions in deploy.go and is currently not utilized anywhere within the codebase.
- jupyter-install-python-packages OdhDocument - jupyter OdhApplication - deploy-python-model and create-jupyter-notebook OdhQuickStart Signed-off-by: Wen Zhou <[email protected]>
* chore: split upgrade.go into 3 files Signed-off-by: Wen Zhou <[email protected]> * update: code review Signed-off-by: Wen Zhou <[email protected]> * revert: keep return error for the case of readfile etc Signed-off-by: Wen Zhou <[email protected]> * Update pkg/cluster/cluster_config.go Co-authored-by: Bartosz Majsak <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]>
we cannot apply this change in RHOAI, because the webhook part is not here This reverts commit c35320b.
…#941) This change introduces types for easy re-use of labels. The idea is not only to extract "magic strings" and avoid repetitions, but primarily to provide structured and unified way for re-using common labels which can be easily discovered and assisted by the code completion.
* fix: properly updates config map Previously the desired configmap state was overwritten by existing version fetched using client.Get. Includes test which fails without the patched function. * chore(lint): fixes formatting Signed-off-by: Wen Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bunch of chore and fix for https://issues.redhat.com/browse/RHOAIENG-4966