update(dashboard): do not set owner on CR #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <[email protected]>
|
Do we need to remove the ownerref for existing instances? |
|
Also we can include this in 2.9? |
good question. |
Signed-off-by: Wen Zhou <[email protected]>
|
I think this should be good to go in 2.9 |
|
i will sync it to 2.9 #229 |
3 tasks
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Mar 20, 2024
* update(dashboard): do not set owner on CR Signed-off-by: Wen Zhou <[email protected]> * update: handle upgrade case to unset ownerreference if already exist Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/RHOAIENG-3963
live build: quay.io/wenzhou/rhods-operator-catalog:v2.10.3963
will need backport to ODH