Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TC Check value for serverless cert on CSV #2010

Conversation

asanzgom
Copy link
Contributor

@asanzgom asanzgom commented Nov 7, 2024

RHOAIENG-14530 Check value for serverless cert on CSV

@asanzgom asanzgom self-assigned this Nov 7, 2024
@asanzgom asanzgom added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Nov 7, 2024
@@ -99,6 +99,23 @@
Wait For Pods Numbers 0 namespace=${KNATIVESERVING_NS}
... label_selector=${KNATIVE_SERVING_CONTROLLER_LABEL_SELECTOR} timeout=300

Check value for serverless cert on CSV

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Check value for serverless cert on CSV' has too many keywords inside (12/10)
Check value for serverless cert on CSV
[Documentation] Check value for serverless cert on CSV
[Tags] Operator RHOAIENG-14530 Smoke
${rc} ${json_derulo}= Run And Return Rc And Output

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${rc}' is assigned but not used
[Documentation] Check value for serverless cert on CSV
[Tags] Operator RHOAIENG-14530 Smoke
${rc} ${json_derulo}= Run And Return Rc And Output
... oc get ClusterServiceVersion -l ${OPERATOR_SUBSCRIPTION_LABEL} -n ${OPERATOR_NAMESPACE} -o jsonpath='{.items[].metadata.annotations.operatorframework\\.io/initialization-resource}'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (191/120)
${rc} ${json_derulo}= Run And Return Rc And Output
... oc get ClusterServiceVersion -l ${OPERATOR_SUBSCRIPTION_LABEL} -n ${OPERATOR_NAMESPACE} -o jsonpath='{.items[].metadata.annotations.operatorframework\\.io/initialization-resource}'
Log To Console ${json_derulo}
&{my_dict}= Create Dictionary

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning test

Local variable '${my_dict}' is overwritten before usage
${rc} ${json_derulo}= Run And Return Rc And Output
... oc get ClusterServiceVersion -l ${OPERATOR_SUBSCRIPTION_LABEL} -n ${OPERATOR_NAMESPACE} -o jsonpath='{.items[].metadata.annotations.operatorframework\\.io/initialization-resource}'
Log To Console ${json_derulo}
&{my_dict}= Create Dictionary

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
... oc get ClusterServiceVersion -l ${OPERATOR_SUBSCRIPTION_LABEL} -n ${OPERATOR_NAMESPACE} -o jsonpath='{.items[].metadata.annotations.operatorframework\\.io/initialization-resource}'
Log To Console ${json_derulo}
&{my_dict}= Create Dictionary
${my_dict}= Load Json String ${json_derulo}

Check notice

Code scanning / Robocop

Variable '{{ variable_name }}' may overwrite similar variable inside '{{ block_name }}' {{ block_type }}. Note that variables are case-insensitive, and also spaces and underscores are ignored. Note test

Variable '${my_dict}' may overwrite similar variable inside 'Check value for serverless cert on CSV' TestCase. Note that variables are case-insensitive, and also spaces and underscores are ignored.
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
565 0 0 565 100

Copy link

sonarcloud bot commented Nov 7, 2024

@asanzgom
Copy link
Contributor Author

asanzgom commented Nov 7, 2024

rhods-ci-pr-test/3453/ passed successfully

Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asanzgom asanzgom merged commit 8b448e1 into red-hat-data-services:master Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants