Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft]Add authorino operator only for odh nightly #1311

Closed
wants to merge 1 commit into from
Closed

[Draft]Add authorino operator only for odh nightly #1311

wants to merge 1 commit into from

Conversation

aloganat
Copy link
Contributor

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
448 0 0 448 100

@aloganat aloganat changed the title Add authorino operator only for odh nightly [Draft]Add authorino operator only for odh nightly Mar 20, 2024
jstourac
jstourac reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙂

But since the latest changes in release plans and since the Authorino withdrawal hasn't been merged for RHOAI 2.9 branch yet red-hat-data-services/rhods-operator#230, I think we should just run against OCP 4.14 for now. With that we don't need to touch this code at all.

@jstourac
Copy link
Member

I'm not sure whether we sill need and want this? 🤔

@jiridanek
Copy link
Member

Imo yes, authorino is going to come sooner or later, and nobody removed it from upstream odh, as far as I know.

@jstourac
Copy link
Member

Imo yes, authorino is going to come sooner or later, and nobody removed it from upstream odh, as far as I know.

Yeah, but this PR is to install it against ODH-nighly only, which was okay up to last week for RHOAI, but then plan changed, so I'm not sure whether this is still needed 🙂

@jstourac
Copy link
Member

Just for the reference - Red Hat Authorino is now available on OCP4.15 - https://issues.redhat.com/browse/RHOAIENG-4710.

@aloganat aloganat closed this by deleting the head repository Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@jiridanek jiridanek jiridanek approved these changes

@kobihk kobihk Awaiting requested review from kobihk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloganat @jstourac @jiridanek