Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Navigation - Fixed chevron not toggling, and used add/remove class functions #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Vertical Navigation - Fixed chevron not toggling, and used add/remove class functions #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/navigation/js/honeycomb.navigation.vertical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ const toggle = ( e, a ) => {
e.preventDefault();
const parent = a.parentElement;
if (parent.className.match(activeClass) !== null) {
parent.className = parent.className.replace(parentActiveClass, '').replace(activeClass, '');
$(parent).removeClass(parentActiveClass + " " + activeClass);
} else {
parent.className = parent.className + ` ${parentActiveClass}`;
$(parent).addClass(parentActiveClass + " " + activeClass);
}
};

Expand All @@ -54,18 +54,18 @@ const update = ( e, nav, a ) => {
// Remove all active classes.
let items = nav.querySelectorAll(`.${activeClass}`);
for (let i=0; i<items.length; i++) {
const re = new RegExp(activeClass, 'g');
items[i].className = items[i].className.replace(re, '');
$(items[i]).removeClass(parentActiveClass + " " + activeClass);
}

var parent = a.parentElement;
// Add active class to parent.
a.parentElement.className = a.parentElement.className + ` ${activeClass}`;
$(parent).addClass (activeClass);

// Add parent active class to parent list items.
let el = a.parentElement.parentElement;
while (el.className.match('nav--vertical') === null) {
if (el.nodeName === 'LI') {
el.className = el.className + ` ${parentActiveClass}`;
$(el).addClass(parentActiveClass);
}

el = el.parentElement;
Expand Down