Simplify ChangedFilesDetector

[staabm]

remove unnecessary/redundant IO operations.

drive-by cleanup while looking into rectorphp/rector#8966

[staabm]

this method did the same thing as getFilePathCacheKey, therefore just drop it and save unnecessary re-hash'ing of files, we already hashed before

[samsonasik]

fileInfoCacheKey is cache key, while file hash is hashed of file, seems different

[staabm]

it has the same content though - see the impl is equivalent

rector-src/src/Caching/Detector/ChangedFilesDetector.php

Lines 96 to 104 in c59c83a

	private function getFilePathCacheKey(string $filePath): string
	{
	return $this->fileHasher->hash($this->resolvePath($filePath));
	}
	private function hashFile(string $filePath): string
	{
	return $this->fileHasher->hashFiles([$this->resolvePath($filePath)]);
	}

both just contain the hash of the file-path-content

[samsonasik]

• the hash() method using hash() function.

rector-src/src/Util/FileHasher.php

Lines 17 to 19 in c59c83a

	public function hash(string $string): string
	{
	return hash($this->getAlgo(), $string);

• the hashFiles() method using hash_file() function.

rector-src/src/Util/FileHasher.php

Lines 27 to 32 in c59c83a

	public function hashFiles(array $files): string
	{
	$configHash = '';
	$algo = $this->getAlgo();
	foreach ($files as $file) {
	$hash = hash_file($algo, $file);

so the usage seems different ...

[samsonasik]

I tested that hash() have different result vs hash_file(), see below:

➜  rector-src git:(main) php -a
Interactive shell

php > echo hash('xxh128', 'vendor/autoload.php');
ed4ee810129ade2015db3142c912be83

php > echo hash_file('xxh128', 'vendor/autoload.php');
d69f0ce7c725ec2c59342d08f047a9ad

so the change seems different.

[samsonasik]

I am closing this as hash() vs hash_file() has different result, which seems on purpose to get key path vs value content of file, see

#6662 (comment)