Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up array_values() on StmtKeyNodeVisitor #6612

Closed
wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

Already covered previously on indexer

// on refresh, early reindex node attributes
// due to PHPStan doing printing internally on process nodes
// using reindex via NodeVisitor on purpose to ensure reindex happen even on deep node changed
if ($formerMutatingScope instanceof MutatingScope) {
$nodeTraverser = new NodeTraverser(new ReIndexNodeAttributeVisitor());
$stmts = $nodeTraverser->traverse($stmts);
}

On refresh process.

On early scan, index always start from 0.

@samsonasik
Copy link
Member Author

Closing for now, not really different. Avoid future unwanted behaviour.

@samsonasik samsonasik closed this Dec 19, 2024
@samsonasik samsonasik deleted the samsonasik-patch-1 branch December 19, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant