skip on assign

rules-tests/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector/Fixture/skip_on_assign.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiveTypeRector\Fixture;
+
+class SkipOnAssign
+{
+    public function run(?\DateTimeImmutable $param)
+    {
+        if (null === ($paramValue = $param)) {
+            return 'no';
+        }
+
+        return $paramValue;
+    }
+}

rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php

@@ -13,7 +13,6 @@
 use PhpParser\Node\Expr\Instanceof_;
 use PhpParser\Node\Name\FullyQualified;
 use PHPStan\Type\ObjectType;
-use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
 use Rector\StaticTypeMapper\ValueObject\Type\AliasedObjectType;
@@ -88,15 +87,15 @@ private function processConvertToExclusiveType(
         ObjectType $objectType,
         Expr $expr,
         Identical|NotIdentical $binaryOp
-    ): BooleanNot|Instanceof_ {
+    ): BooleanNot|Instanceof_|null {
+        if ($expr instanceof Assign) {
+            return null;
+        }
+
         $fullyQualifiedType = $objectType instanceof ShortenedObjectType || $objectType instanceof AliasedObjectType
             ? $objectType->getFullyQualifiedName()
             : $objectType->getClassName();
 
-        if ($expr instanceof Assign) {
-            $expr->setAttribute(AttributeKey::WRAPPED_IN_PARENTHESES, true);
-        }
-
         $instanceof = new Instanceof_($expr, new FullyQualified($fullyQualifiedType));
         if ($binaryOp instanceof NotIdentical) {
             return $instanceof;

rules/DeadCode/Rector/If_/RemoveDeadInstanceOfRector.php

@@ -111,7 +111,6 @@ private function refactorStmtAndInstanceof(If_ $if, Instanceof_ $instanceof): nu
         }
 
         if ($instanceof->expr instanceof Assign) {
-            $instanceof->expr->getAttribute(AttributeKey::WRAPPED_IN_PARENTHESES, false);
             $assignExpression = new Expression($instanceof->expr);
             return array_merge([$assignExpression], $if->stmts);
         }