Add readonly by default on new promoted property

src/PhpParser/Node/NodeFactory.php

@@ -45,10 +45,13 @@
 use Rector\Exception\ShouldNotHappenException;
 use Rector\NodeDecorator\PropertyTypeDecorator;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Php\PhpVersionProvider;
 use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\PostRector\ValueObject\PropertyMetadata;
 use Rector\StaticTypeMapper\StaticTypeMapper;
+use Rector\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersionFeature;
 
 /**
  * @see \Rector\Tests\PhpParser\Node\NodeFactoryTest
@@ -65,7 +68,8 @@ public function __construct(
         private PhpDocInfoFactory $phpDocInfoFactory,
         private StaticTypeMapper $staticTypeMapper,
         private PropertyTypeDecorator $propertyTypeDecorator,
-        private SimpleCallableNodeTraverser $simpleCallableNodeTraverser
+        private SimpleCallableNodeTraverser $simpleCallableNodeTraverser,
+        private PhpVersionProvider $phpVersionProvider,
     ) {
     }
 
@@ -291,6 +295,11 @@ public function createPromotedPropertyParam(PropertyMetadata $propertyMetadata):
         $propertyFlags = $propertyMetadata->getFlags();
         $param->flags = $propertyFlags !== 0 ? $propertyFlags : Modifiers::PRIVATE;
 
+        // make readonly by default
+        if ($this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::READONLY_PROPERTY)) {
+            $param->flags |= Modifiers::READONLY;
+        }
+
         return $param;
     }
 

tests/Issues/EmptyLongArraySyntax/Fixture/empty_long_array.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\EmptyLongArraySyntax\Fixture;
+
+use Rector\Tests\Issues\EmptyLongArraySyntax\Source\ParentWithEmptyLongArray;
+
+final class EmptyLongArray extends ParentWithEmptyLongArray
+{
+    public function run()
+    {
+    }
+}
+
+?>

tests/NodeManipulator/ClassDependencyManipulatorTest.php

@@ -46,7 +46,6 @@ public function testEmptyClass(): void
     public function testSingleMethod(): void
     {
         $someClass = new Class_(new Identifier('SingleMethodClass'));
-
         $this->setNamespacedName($someClass);
 
         $someClass->stmts[] = new ClassMethod('firstMethod');

tests/NodeManipulator/Fixture/expected_class_const_property.php.inc

@@ -5,7 +5,7 @@ class ConstantProperties
     const SOME_CONST = 'value';
     public $someProperty;
     public $anotherProperty;
-    public function __construct(private \EventDispatcherInterface $eventDispatcher)
+    public function __construct(private readonly \EventDispatcherInterface $eventDispatcher)
     {
     }
 }

tests/NodeManipulator/Fixture/expected_empty_class.php.inc

@@ -2,7 +2,7 @@
 
 class EmptyClass
 {
-    public function __construct(private \EventDispatcherInterface $eventDispatcher)
+    public function __construct(private readonly \EventDispatcherInterface $eventDispatcher)
     {
     }
 }

tests/NodeManipulator/Fixture/expected_method_and_property.php.inc

@@ -3,7 +3,7 @@
 class ClassWithMethodAndProperty
 {
     private $someProperty;
-    public function __construct(private \EventDispatcherInterface $eventDispatcher)
+    public function __construct(private readonly \EventDispatcherInterface $eventDispatcher)
     {
     }
     function someMethod()

tests/NodeManipulator/Fixture/expected_single_method.php.inc

@@ -2,7 +2,7 @@
 
 class SingleMethodClass
 {
-    public function __construct(private \EventDispatcherInterface $eventDispatcher)
+    public function __construct(private readonly \EventDispatcherInterface $eventDispatcher)
     {
     }
     function firstMethod()

tests/NodeManipulator/Fixture/expected_single_property.php.inc

@@ -3,7 +3,7 @@
 class ClassWithSingleProperty
 {
     private $someProperty;
-    public function __construct(private \EventDispatcherInterface $eventDispatcher)
+    public function __construct(private readonly \EventDispatcherInterface $eventDispatcher)
     {
     }
 }