[Php54] No need reprint when array is just created on LongArrayToShor…

…tArrayRector (#6206)

* [Php54] No need reprint when array is just created on LongArrayToShortArrayRector

* [Php54] No need reprint when array is just created on LongArrayToShortArrayRector

rules/Php54/Rector/Array_/LongArrayToShortArrayRector.php

@@ -66,6 +66,12 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        // no kind attribute yet, it means just created
+        // no need to reprint, it already will be short array by default
+        if (! $node->hasAttribute(AttributeKey::KIND)) {
+            return null;
+        }
+
         if ($node->getAttribute(AttributeKey::KIND) === Array_::KIND_SHORT) {
             return null;
         }

tests/Issues/CountArrayLongToShort/CountArrayLongToShortTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\CountArrayLongToShort;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class CountArrayLongToShortTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/CountArrayLongToShort/Fixture/count_to_empty_array_compare.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\Issues\CountArrayLongToShort\Fixture;
+
+final class CountToEmptyArrayCompare
+{
+    public function run()
+    {
+        $data = [];
+
+        if (count($data) === 0) {
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\CountArrayLongToShort\Fixture;
+
+final class CountToEmptyArrayCompare
+{
+    public function run()
+    {
+        $data = [];
+
+        if ($data === []) {
+        }
+    }
+}
+
+?>

tests/Issues/CountArrayLongToShort/config/configured_rule.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
+use Rector\Config\RectorConfig;
+use Rector\Php54\Rector\Array_\LongArrayToShortArrayRector;
+
+return RectorConfig::configure()
+    ->withRules([
+        CountArrayToEmptyArrayComparisonRector::class,
+        LongArrayToShortArrayRector::class,
+    ]);