Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changesets #15

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Changesets #15

merged 5 commits into from
Sep 18, 2023

Conversation

AkifumiSato
Copy link
Collaborator

@AkifumiSato AkifumiSato commented Sep 17, 2023

change

  • release workflowの追加
  • snapshot release(@next) workflowの追加

note

  • snapshot releaseはこのPRで検証できる
  • 本リリースフローは Release workflow #5 でコマンドや.npmrc周り検証済み
    • 実際にはこのPRマージ後に自動で作成されるリリースPRマージしないとリリース検証できないので、今段階でできる検証があまりなさそうに思ってます

参考

https://efcl.info/2023/07/17/regular-updates-by-changesets/
https://turbo.build/repo/docs/handbook/publishing-packages/versioning-and-publishing

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2023

🦋 Changeset detected

Latest commit: 8f988b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@location-state/core Patch
@location-state/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,6 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル名が気になるんですが自動生成で設定などはできなそうでした(調査不足だったらすいません)。
一応任意の名前にも変更可能ですが、弊害あるわけではないし公式のやり方に従おうかなと思ってそのままにしてます。
https://github.com/changesets/changesets/blob/main/docs/common-questions.md#each-changeset-is-its-own-file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このファイルってリリースすると削除される一時的なものですよね?
だったら気にする必要ないかなー

"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["example-next"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いちいち指定したくはないんですが、現状バグってて検出されてしまうので明示的に指定しています。
changesets/changesets#833

Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容自体はスキル不足で精査できてませんがLGTM!
試しながら改善していけばいいよねということで!

@AkifumiSato AkifumiSato merged commit cd03936 into main Sep 18, 2023
1 check passed
@AkifumiSato AkifumiSato deleted the changesets branch September 18, 2023 08:26
@AkifumiSato
Copy link
Collaborator Author

こちらもマージ後ですが、@nextがリリースされてました。
https://www.npmjs.com/package/@location-state/core?activeTab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants