Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stores props in LocationStateProvider #13

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

AkifumiSato
Copy link
Collaborator

LocationStateProviderstoresを指定できるようにしました。

Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ひとまず

packages/location-state-core/src/provider.tsx Outdated Show resolved Hide resolved
Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

些細なコメントしたけどLGTM!!

packages/location-state-core/src/provider.tsx Outdated Show resolved Hide resolved
packages/location-state-core/src/provider.tsx Outdated Show resolved Hide resolved
@AkifumiSato AkifumiSato merged commit 9019ea4 into main Sep 15, 2023
1 check passed
@AkifumiSato AkifumiSato deleted the provider-with-store-props branch September 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants