Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Function Name to reflect new Tensorflow interface. #2143

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

siyerp
Copy link
Contributor

@siyerp siyerp commented Aug 12, 2024

Changed a function call name to reflect a more recent version of tensorflow.

Description

I changed .reset_states() to .reset_state().
I was getting an error along the lines of "'Mean' object has no attribute 'reset_states'." It seems that in a newer version of tensorflow, the function has been renamed to .reset_state.

Related Issues

References

Checklist:

  • [ x] I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • [ x] I have signed the commits, e.g. git commit -s -m "your commit message".
  • [ x] This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro and others added 4 commits June 5, 2024 22:08
Staging to main: Fix bug with Sklearn and info for contributors
Staging to main: Fix to NewsRec, LightFM to extras, issue with scipy
Changed a function call name to reflect a more recent version of tensorflow.
@siyerp siyerp changed the title Patch 2 Changing Function Name to reflect new Tensorflow interface. Aug 12, 2024
@miguelgfierro
Copy link
Collaborator

@siyerp thanks for this.

Can you share what TF version are you using?

FYI @daviddavo

@daviddavo
Copy link
Collaborator

It doesn't appear in the changelog, but they changed it in 2.5.

I ran the tests on my machine and they work

@siyerp
Copy link
Contributor Author

siyerp commented Aug 13, 2024

@miguelgfierro I'm using Tensorflow 2.16, but even in the example notebook it says it's using Tensorflow 2.8, and according to to @daviddavo 's comment, even that should have had this issue.

@miguelgfierro miguelgfierro merged commit 34b7b09 into recommenders-team:staging Aug 15, 2024
1 of 38 checks passed
@miguelgfierro
Copy link
Collaborator

Merging this.

Please @siyerp notice that #2111 is in the works. If you want to collaborate on this effort, please let me know

@hao-joey-zhang
Copy link

Had the same issue, try tensorflow==2.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants