Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to select the preferred language for subs (Resolves #239) #393

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

JohnVictoryz
Copy link
Contributor

@JohnVictoryz JohnVictoryz commented May 17, 2024

Added option to select the preferred language for subs basically just searches for the preferred sub language if no sub is selected manually

also includes two functions that allows you to convert from the name of the language to the language code and another one that does the opposite

@JohnVictoryz
Copy link
Contributor Author

man fuck git conflicts they don't make sense

@itsmechinmoy
Copy link
Contributor

👀

@itsmechinmoy
Copy link
Contributor

@JohnVictoryz will it still show the option for other language subs even if the server/extension doesn't support that language?

@JohnVictoryz
Copy link
Contributor Author

@JohnVictoryz will it still show the option for other language subs even if the server/extension doesn't support that language?

What do you mean this option just is for having preferred subs so if you want to change the subs to another language you can still change it to your preferred one I also was hoping to have a list of languages from like a library there is one but when you call the function it doesnt return a dictionary/array so I pretty much said f it and said that there arent a lot of subs for anime available anyway so I figured that I should just probably make a list with the most popular ones and just them

@JohnVictoryz JohnVictoryz marked this pull request as draft September 15, 2024 18:30
@JohnVictoryz
Copy link
Contributor Author

i have this draft as i test it a bit and then i will undraft

@JohnVictoryz JohnVictoryz marked this pull request as ready for review September 15, 2024 18:51
@JohnVictoryz
Copy link
Contributor Author

done

@grayankit
Copy link

grayankit commented Nov 5, 2024

you are done?
if so can you provide some screenshots

@JohnVictoryz
Copy link
Contributor Author

you are done? if so can you provide some screenshots

i am done but what do you mean by screenshots there really is nothing fancy its just a menu that you select a language and the rest is code

@itsmechinmoy
Copy link
Contributor

@grayankit tested?

@grayankit
Copy link

Working on another thing will do it sometime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants