-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to select the preferred language for subs (Resolves #239) #393
base: dev
Are you sure you want to change the base?
Conversation
man fuck git conflicts they don't make sense |
👀 |
@JohnVictoryz will it still show the option for other language subs even if the server/extension doesn't support that language? |
What do you mean this option just is for having preferred subs so if you want to change the subs to another language you can still change it to your preferred one I also was hoping to have a list of languages from like a library there is one but when you call the function it doesnt return a dictionary/array so I pretty much said f it and said that there arent a lot of subs for anime available anyway so I figured that I should just probably make a list with the most popular ones and just them |
i have this draft as i test it a bit and then i will undraft |
done |
you are done? |
i am done but what do you mean by screenshots there really is nothing fancy its just a menu that you select a language and the rest is code |
@grayankit tested? |
Working on another thing will do it sometime |
Added option to select the preferred language for subs basically just searches for the preferred sub language if no sub is selected manually
also includes two functions that allows you to convert from the name of the language to the language code and another one that does the opposite