Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: #154 cameraMode=pan on touch devices #301

Merged
merged 6 commits into from
Dec 24, 2024
Merged

Conversation

mcm97
Copy link

@mcm97 mcm97 commented Dec 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If the camera mode 'pan' is set, the behavior on touch devices still is 'rotate' for touch events with one finger.

Issue Number: #154

What is the new behavior?

If the mode is not set to 'rotate', touch events with one finger pan the graph.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

If the expected behavior for events with one finger on touch devices is 'rotate' the camera mode has to be explicitly set to 'rotate'.

Other information

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit c6123bf
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/67693df26120540008ad352b
😎 Deploy Preview https://deploy-preview-301--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 25eb4d9 into reaviz:master Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants