SWS/S&M: Toggle selected FX bypass for selected tracks #1444
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
That last push falls back to the legacy behavior if the FX window is not open for a selected track, i.e. it toggles the selected FX index for the track(s) if it's a valid index. |
jameadows
force-pushed
the
issue-1443
branch
from
73f7a64
to
d467f49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
SnM/SnM_FX.cpp
Outdated
| { | ||
| int index=-1; | ||
| // enumerate selected FX | ||
| while( (index = CF_EnumSelectedFX(fxChain, index)) >= 0) |
There was a problem hiding this comment.
fxChain is NULL at this point, so the action fails to find the last active FX when the chain is closed. The last active FX index is stored in fxId.
Updating the meaning of "selected FX" from "the last FX shown in the chain" to "all selected FXs in the chain" is interesting, but I think it should be done across all SWS actions dealing with "selected FX". #1432 (comment)
There was a problem hiding this comment.
fxChainis NULL at this point, so the action fails to find the last active FX when the chain is closed. The last active FX index is stored infxId.
Strange, I have the same code in both blocks, but I remember testing this with FX window opened and closed. Anyhow, sorry, I pushed an update that reverts to the previous behavior if the FX window is not opened.
Updating the meaning of "selected FX" from "the last FX shown in the chain" to "all selected FXs in the chain" is interesting, but I think it should be done across all SWS actions dealing with "selected FX". #1432 (comment)
IIUC the original request was to make the action behave the same as the menu command (Ctrl-B). I searched for other actions that affected selected FX, are these what you were wanting to include?:
SWS/S&M: Show FX chain for selected tracks (selected FX)
SWS/S&M: Float selected FX for selected tracks
SWS/S&M: Unfloat selected FX for selected tracks
SWS/S&M: Toggle float selected FX for selected tracks
SWS/S&M: Move selected FX up in chain for selected tracks
SWS/S&M: Move selected FX down in chain for selected tracks
SWS/S&M: Remove selected FX for selected tracks
SWS/S&M: Toggle selected FX online/offline for selected tracks
SWS/S&M: Set selected FX online for selected tracks
SWS/S&M: Set selected FX offline for selected tracks
SWS/S&M: Bypass selected FX for selected tracks
SWS/S&M: Unbypass selected FX for selected tracks
SWS/S&M: Trigger preset for selected FX of selected track (MIDI/OSC only)
SWS/S&M: Trigger next preset for selected FX of selected tracks
SWS/S&M: Trigger previous preset for selected FX of selected tracks
SWS/S&M: Reassign MIDI learned channels of selected FX for selected tracks (prompt)
For each selected track, if the effects window is open then iterate through effects and toggle the enabled state. Fall back to previous behavior if the effects window for the track is not opened, i.e. toggle the current fx index for the track. Fixes reaper-oss#1443
|
✅ Build sws 448-master completed (commit 745db2c69f by @) Windows 64-bitWindows 32-bitLinux x86 64-bitLinux x86 32-bitLinux ARM 64-bitLinux ARM 32-bit |
|
Hi folks, |
Iterate through selected effects on selected tracks and toggle
the enabled state.
Fixes #1443