Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): upgrade base image to ubuntu 24.04 #98

Conversation

wirespecter
Copy link
Contributor

@wirespecter wirespecter changed the title build(docker): upgrade base image to ubuntu 24.04 wip - build(docker): upgrade base image to ubuntu 24.04 Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.66%. Comparing base (3ef33c3) to head (8cb1345).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #98      +/-   ##
=========================================
- Coverage    3.78%   3.66%   -0.12%     
=========================================
  Files           6       6              
  Lines         185     191       +6     
=========================================
  Hits            7       7              
- Misses        178     184       +6     

see 2 files with indirect coverage changes

@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch 3 times, most recently from 7f5dc31 to db9cb56 Compare July 15, 2024 08:18
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 15, 2024
@wirespecter wirespecter marked this pull request as ready for review July 15, 2024 08:23
@wirespecter wirespecter changed the title wip - build(docker): upgrade base image to ubuntu 24.04 build(docker): upgrade base image to ubuntu 24.04 Jul 15, 2024
@wirespecter wirespecter requested a review from mdonadoni July 15, 2024 08:23
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 15, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from db9cb56 to a8e31a4 Compare July 15, 2024 14:40
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally when running all the examples on Kubernetes. Just left one comment about the Dockerfile changes!

Dockerfile Outdated Show resolved Hide resolved
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 16, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from a8e31a4 to c539d20 Compare July 16, 2024 13:58
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 16, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from c539d20 to 0c44114 Compare July 16, 2024 14:00
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 16, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from 0c44114 to 3bb7b7e Compare July 16, 2024 14:09
wirespecter added a commit to wirespecter/reana-workflow-engine-snakemake that referenced this pull request Jul 16, 2024
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from 3bb7b7e to 6fd313b Compare July 16, 2024 14:09
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@wirespecter wirespecter force-pushed the ubuntu-24.04-docker-image-upgrade branch from 6fd313b to 6961a8c Compare July 17, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: upgrade all base docker images to ubuntu 24.04
2 participants