config: lower job-status-consumer prefetch count #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 15 15
Lines 1327 1327
=======================================
Hits 905 905
Misses 422 422
|
tiborsimko
reviewed
Mar 31, 2022
| @@ -52,7 +52,7 @@ | |||
| """List of file mime-type prefixes that can be previewed directly from the server.""" | |||
|
|
|||
| REANA_JOB_STATUS_CONSUMER_PREFETCH_COUNT = int( | |||
| os.getenv("REANA_JOB_STATUS_CONSUMER_PREFETCH_COUNT", 200) | |||
| os.getenv("REANA_JOB_STATUS_CONSUMER_PREFETCH_COUNT", 10) | |||
There was a problem hiding this comment.
Can you leave a note in CHANGES.rst about this change? Something like:
- Changes default consumer prefetch count to handle 10 messages instead of 200 in order to reduce the probability of 406 PRECONDITION errors on message ack.
You can put the same message to reana repository.
VMois
force-pushed
the
change-prefetch-count
branch
from
5c6c757
to
be74f85
Compare
tiborsimko
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #436