Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: add yarn.lock file #187

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

mvidalgarcia
Copy link
Member

@mvidalgarcia mvidalgarcia commented Jun 29, 2021

partially addresses #109

Apparently, [email protected], released 4h ago is causing the troubles.
Nothing is reported in their GH issues so far: https://github.com/DocSpring/craco-less/issues

To pin craco-less version in @semantic-ui-react/craco-less and generate a working yarn.lock, this patch was used:

diff --git a/reana-ui/package.json b/reana-ui/package.json
index 47a1b1a..5d2ee45 100644
--- a/reana-ui/package.json
+++ b/reana-ui/package.json
@@ -53,5 +53,8 @@
     "prettier": "^2.1.2",
     "semantic-ui-less": "^2.4.1",
     "source-map-explorer": "^2.5.0"
+  },
+  "resolutions": {
+    "@semantic-ui-react/craco-less/craco-less": "1.17.1"
   }
 }

Copy link
Member

@ParthS007 ParthS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR. Tested, works fine!

@mvidalgarcia mvidalgarcia merged commit 2dbec35 into reanahub:master Jun 29, 2021
@mvidalgarcia mvidalgarcia deleted the 109-yarn-lock branch June 29, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants