fix(set_workflow_status): publish workflows to submission queue (#691) #691
Conversation
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maint-0.9 #691 +/- ##
=============================================
+ Coverage 59.46% 60.00% +0.54%
=============================================
Files 32 32
Lines 3298 3328 +30
=============================================
+ Hits 1961 1997 +36
+ Misses 1337 1331 -6
|
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
| @@ -1374,6 +1413,10 @@ def set_workflow_status(workflow_id_or_name, user): # noqa | |||
| description: Required. New workflow status. | |||
| required: true | |||
| type: string | |||
| enum: | |||
| - start | |||
There was a problem hiding this comment.
Hmm, this may look a bit inconsistent, it would be preferable to use either "start/stop/delete" (verbs) or "started/stopped/deleted" (nouns) everywhere ... but I guess this may not be for now.
(... for the API 1.0 stabilisation we could also clean mixing params/options for execution with all-runs/workspace for deletion...)
There was a problem hiding this comment.
Yeah, this comes from RWC, so not much we can do as of now: https://github.com/reanahub/reana-workflow-controller/blob/f1764ed7101fa9d30516b8687b7e5ef4ae8781fe/reana_workflow_controller/rest/workflows_status.py#L34-L37
…ahub#691) When starting a new workflow, publish the workflow to the submission queue instead of executing the workflow immediately by calling `set_workflow_status` in workflow-controller. Closes reanahub#690
When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
set_workflow_statusin workflow-controller.Depends on #689
Closes #690