rest: make details available for shared workflows #658

DaanRosendal · 2023-12-15T11:29:54Z

Command	Allowed
delete	❌
diff	✅
logs	✅
restart	❌
start	❌
status	✅
stop	❌
share-add	❌
share-remove	❌
share-status	❌
close	❌
open	❌
download	✅
du	✅
ls	✅
mv	❌
prune	❌
rm	❌
upload	❌
retention-rules-list	✅

Closes #651, closes #650

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information. Closes reanahub/reana-client#687

Adds two endpoints: - fetch who shared workflows with the user - fetch who the user shared workflows with Closes reanahub#648 and reanahub#649

Closes reanahub/reana-ui#368

Closes reanahub#651, closes reanahub#650

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information. Closes reanahub/reana-client#687

Adds two endpoints: - fetch who shared workflows with the user - fetch who the user shared workflows with Closes reanahub#648 and reanahub#649

Closes reanahub/reana-ui#368

Closes reanahub#651, closes reanahub#650

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

mdonadoni · 2024-08-20T13:07:09Z

Latest version before rebase: ef5010e

There are still some comments left to be addressed from previous PRs.

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information. Closes reanahub/reana-client#687

Adds two endpoints: - fetch who shared workflows with the user - fetch who the user shared workflows with Closes reanahub#648 and reanahub#649

Closes reanahub/reana-ui#368

Closes reanahub#651, closes reanahub#650

mdonadoni · 2024-08-29T10:33:46Z

Ready to be reviewed, squashed and merged

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

…anahub#658)

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

…#658) Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information. Closes reanahub/reana-client#687

Adds two endpoints: - fetch who shared workflows with the user - fetch who the user shared workflows with Closes reanahub#648 and reanahub#649

Closes reanahub/reana-ui#368

Closes reanahub#651, closes reanahub#650

tiborsimko

Works nicely 👍 with

- r-client #692
- r-client-go #153
- r-ui #375
- r-server #658
- r-workflow-controller #552
- r-commons #429
- r-db #216

Kept separate commits as elsewhere, amended commit log headlines, increased reana-db and pytest-reana dependency versions.

codecov · 2024-09-04T16:52:16Z

Codecov Report

Attention: Patch coverage is 42.69663% with 51 lines in your changes missing coverage. Please review.

Project coverage is 60.01%. Comparing base (d1cd1a5) to head (50495fc).
Report is 9 commits behind head on master.

Files with missing lines	Patch %	Lines
reana_server/rest/workflows.py	35.29%	33 Missing ⚠️
reana_server/rest/users.py	52.63%	18 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   60.84%   60.01%   -0.83%     
==========================================
  Files          33       32       -1     
  Lines        3463     3509      +46     
==========================================
- Hits         2107     2106       -1     
- Misses       1356     1403      +47

Files with missing lines	Coverage Δ
reana_server/rest/users.py	`42.22% <52.63%> (+5.18%)`	⬆️
reana_server/rest/workflows.py	`51.04% <35.29%> (-2.46%)`	⬇️

... and 31 files with indirect coverage changes

DaanRosendal force-pushed the feature/shared-workflow-details branch 2 times, most recently from 7ccdab0 to a78f8b4 Compare December 15, 2023 12:23

DaanRosendal force-pushed the feature/shared-workflow-details branch 3 times, most recently from f8aea96 to 6ce6288 Compare March 18, 2024 10:37

DaanRosendal force-pushed the feature/shared-workflow-details branch 2 times, most recently from b813ad6 to 7756714 Compare March 20, 2024 13:44

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add share_workflow endpoint (reanahub#658)

ae3584d

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

test(pytest): rename default_user to user0 (reanahub#658)

b528ea8

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add unshare_workflow endpoint (reanahub#658)

f17f763

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

DaanRosendal force-pushed the feature/shared-workflow-details branch from 7756714 to d440011 Compare March 20, 2024 13:46

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add get_workflow_share_status endpoint (reanahub#658)

e33711a

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add user id to get-you endpoint (reanahub#658)

5fe4a33

Closes reanahub/reana-ui#368

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): make details available for shared workflows (reanahub#658)

d440011

Closes reanahub#651, closes reanahub#650

DaanRosendal mentioned this pull request Mar 20, 2024

rest: add share_workflow endpoint #640

Closed

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add share_workflow endpoint (reanahub#658)

bbe90f3

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

test(pytest): rename default_user to user0 (reanahub#658)

fba3ab4

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add unshare_workflow endpoint (reanahub#658)

3d57279

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add get_workflow_share_status endpoint (reanahub#658)

349d21b

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

DaanRosendal force-pushed the feature/shared-workflow-details branch from d440011 to d1bf9f6 Compare March 20, 2024 14:14

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add user id to get-you endpoint (reanahub#658)

3d371c3

Closes reanahub/reana-ui#368

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): make details available for shared workflows (reanahub#658)

d1bf9f6

Closes reanahub#651, closes reanahub#650

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add share_workflow endpoint (reanahub#658)

50dbd68

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

test(pytest): rename default_user to user0 (reanahub#658)

91a4cf8

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add unshare_workflow endpoint (reanahub#658)

8e60a31

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

DaanRosendal added a commit to DaanRosendal/reana-server that referenced this pull request Mar 20, 2024

feat(rest): add get_workflow_share_status endpoint (reanahub#658)

4f6ed5e

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

This was referenced Aug 20, 2024

rest: add get_workflow_share_status endpoint #644

Closed

rest: add sharing parameters to get_workflows #646

Closed

rest: create endpoints to get sharing users #653

Closed

rest: add user id to get-you endpoint #657

Closed

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

feat(rest): add share_workflow endpoint (reanahub#658)

1c33ec0

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

test(pytest): rename default_user to user0 (reanahub#658)

9729b0e

mdonadoni force-pushed the feature/shared-workflow-details branch from 8c9ecaf to f66d666 Compare August 29, 2024 10:08

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

feat(rest): add unshare_workflow endpoint (reanahub#658)

9953eaf

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

feat(rest): add get_workflow_share_status endpoint (reanahub#658)

3a987a3

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

feat(rest): add user id to get-you endpoint (reanahub#658)

3fc8b9c

Closes reanahub/reana-ui#368

mdonadoni pushed a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

feat(rest): make details available for shared workflows (reanahub#658)

0148633

Closes reanahub#651, closes reanahub#650

mdonadoni added a commit to DaanRosendal/reana-server that referenced this pull request Aug 29, 2024

fix(rest): fix workflow sharing endpoints after rebase (reanahub#658)

f66d666

DaanRosendal and others added 9 commits September 4, 2024 18:42

feat(rest): add endpoint for sharing workflows (reanahub#658)

045d275

Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680

test(pytest): adapt to fixture changes from default_user to user0 (re…

72a6964

…anahub#658)

feat(rest): add endpoint to unshare workflows (reanahub#658)

727c04e

Adds a new endpoint to unshare a workflow. Closes reanahub/reana-client#681

feat(rest): add endpoint to get workflow share status (reanahub#658)

b7d14bb

Adds a new endpoint to retrieve whom a workflow is shared with. Closes reanahub/reana-client#686

feat(rest): add share-related parameters to get_workflows (reanahub…

a72f1ac

…#658) Adds new `shared`, `shared_with` and `shared_by` parameters to the `get_workflows` endpoint to retrieve workflows along with their sharing information. Closes reanahub/reana-client#687

feat(rest): add endpoints to fetch sharing users (reanahub#658)

3a1c5ea

Adds two endpoints: - fetch who shared workflows with the user - fetch who the user shared workflows with Closes reanahub#648 and reanahub#649

feat(rest): add user id to get-you endpoint (reanahub#658)

20246c9

Closes reanahub/reana-ui#368

feat(rest): make details available for shared workflows (reanahub#658)

b274a29

Closes reanahub#651, closes reanahub#650

fix(rest): fix workflow sharing endpoints after changes (reanahub#658)

50495fc

tiborsimko force-pushed the feature/shared-workflow-details branch from f66d666 to 50495fc Compare September 4, 2024 16:47

tiborsimko approved these changes Sep 4, 2024

View reviewed changes

tiborsimko merged commit 50495fc into reanahub:master Sep 4, 2024
14 checks passed

github-actions bot mentioned this pull request Sep 4, 2024

chore(master): release 0.95.0 #679

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rest: make details available for shared workflows #658

rest: make details available for shared workflows #658

DaanRosendal commented Dec 15, 2023

mdonadoni commented Aug 20, 2024

mdonadoni commented Aug 29, 2024

tiborsimko left a comment

codecov bot commented Sep 4, 2024 •

edited

Loading

rest: make details available for shared workflows #658

rest: make details available for shared workflows #658

Conversation

DaanRosendal commented Dec 15, 2023

mdonadoni commented Aug 20, 2024

mdonadoni commented Aug 29, 2024

tiborsimko left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 4, 2024 •

edited

Loading