Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: update to apispec v3 #608

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

mdonadoni
Copy link
Member

Update to apispec v3, as the version used before is not compatible with
PyYAML v6. This commit also removes the marshmallow plugin for apispec,
as the generated OpenAPI spec is different and causes issues with
reana-client. This is due to the fact that the OpenAPI specifications of
marshmallow schemas are now put inside the global definitions object,
instead of being inlined in the endpoint's specification as before.

Closes reanahub/reana-commons#399

@mdonadoni
Copy link
Member Author

CI should pass after releasing new alpha version of reana-commons and pytest-reana

@mdonadoni mdonadoni marked this pull request as ready for review August 4, 2023 10:14
Update to apispec v3, as the version used before is not compatible with
PyYAML v6. This commit also removes the marshmallow plugin for apispec,
as the generated OpenAPI spec is different and causes issues with
reana-client. This is due to the fact that the OpenAPI specifications of
marshmallow schemas are now put inside the global `definitions` object,
instead of being inlined in the endpoint's specification as before.

Closes reanahub/reana-commons#399
@mdonadoni mdonadoni merged commit fa056f4 into reanahub:master Aug 4, 2023
9 checks passed
@mdonadoni mdonadoni deleted the pyyaml-v6 branch August 4, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recheck if upper bound on PyYAML is needed
2 participants