Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: podman-friendly image locations #604

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

tiborsimko
Copy link
Member

Adds fully qualified canonical locations of container images, making the container technology setup podman-friendly.

Closes reanahub/reana#729.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #604 (607e26e) into master (b848c11) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files          32       32           
  Lines        3229     3229           
=======================================
  Hits         1915     1915           
  Misses       1314     1314           

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change also the docker image in run-tests.sh? This applies also to the other repositories

docker run --rm --name postgres__reana-server -p 5432:5432 -e POSTGRES_PASSWORD=mysecretpassword -d postgres:12.13

check_dockerfile () {
docker run -i --rm hadolint/hadolint:v1.18.2 < Dockerfile
}
check_docker_build () {
docker build -t reanahub/reana-server .
}

Adds desired targets and threshold values for code coverage tests in
pull requests.

Removes custom code coverage range to fall back to codecov defaults.
Adds fully qualified canonical locations of container images, making the
container technology setup podman-friendly.

Closes reanahub/reana#729.
@mdonadoni mdonadoni merged commit 607e26e into reanahub:master Aug 10, 2023
11 checks passed
@tiborsimko tiborsimko deleted the podman-friendly branch August 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installation: allow using rootless podman
3 participants