k8s: use unique error messages #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the error messages used to log k8s API errors so that each of them is unique. This will help to debug reanahub#383.
tiborsimko
reviewed
Feb 27, 2023
| @@ -276,7 +276,7 @@ def watch_jobs(self, job_db, app=None): | |||
| :param job_db: Dictionary which contains all current jobs. | |||
| """ | |||
| while True: | |||
| logging.debug("Starting a new stream request to watch Jobs") | |||
| logging.info("Starting a new stream request to watch Jobs") | |||
There was a problem hiding this comment.
Is the change from "debug" to "info" intended on purpose?
There was a problem hiding this comment.
Yes, in this way we can check that when an error occurs the job monitor correctly restarts. Otherwise we would only see the error message, without knowing whether another "watch" request has been made to the Kubernetes API
tiborsimko
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the error messages used to log k8s API errors so
that each of them is unique. This will help to debug #383.