chore(tests): add gherkin test files to reana specifications (#73) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
approved these changes
Sep 18, 2024
mdonadoni
pushed a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
916e92c
to
e5fa83b
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
04ff788
to
315e78e
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
315e78e
to
aed0d4d
Compare
mdonadoni
force-pushed
the
tests-in-spec
branch
from
aed0d4d
to
a9806c0
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
2 times, most recently
from
64226c5
to
37f3644
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
37f3644
to
9f289d3
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
9f289d3
to
f1b6e6b
Compare
mdonadoni
added a commit
to ajclyall/reana-demo-root6-roofit
that referenced
this pull request
Sep 18, 2024
mdonadoni
force-pushed
the
tests-in-spec
branch
from
f1b6e6b
to
9d63e76
Compare
tiborsimko
reviewed
Sep 18, 2024
.github/workflows/ci.yml
Outdated
| wget https://root.cern/download/root_v6.24.02.Linux-ubuntu20-x86_64-gcc9.3.tar.gz | ||
| tar -xzvf root_v6.24.02.Linux-ubuntu20-x86_64-gcc9.3.tar.gz | ||
| # ROOT is needed as Snakemake does not run the workflow steps in containers | ||
| wget https://root.cern/download/root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz |
There was a problem hiding this comment.
Suggested change
| wget https://root.cern/download/root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz | |
| wget -q https://root.cern/download/root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz |
(in order to save many unnecessary lines in the job logs)
.github/workflows/ci.yml
Outdated
| tar -xzvf root_v6.24.02.Linux-ubuntu20-x86_64-gcc9.3.tar.gz | ||
| # ROOT is needed as Snakemake does not run the workflow steps in containers | ||
| wget https://root.cern/download/root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz | ||
| tar -xzvf root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz |
There was a problem hiding this comment.
Suggested change
| tar -xzvf root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz | |
| tar xfz root_v6.32.04.Linux-ubuntu24.04-x86_64-gcc13.2.tar.gz |
(in order to save many unnecessary lines in the job logs)
mdonadoni
force-pushed
the
tests-in-spec
branch
from
9d63e76
to
d88f8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with
reana-client test.