Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): check for the presence of concrete PR number #15

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

tiborsimko
Copy link
Member

  • ci(commitlint): check for the presence of concrete PR number

    Enrich commitlint checker in order to check the precise PR number in the
    commit log headline.

  • ci(shellcheck): fix exit code propagation

    Return properly the exit code status of shellcheck command when looping
    through shell script files.

tiborsimko added a commit to tiborsimko/reana-demo-cms-dimuon-mass-spectrum that referenced this pull request Jan 26, 2024
Return properly the exit code status of shellcheck command when looping
through shell script files.
tiborsimko added a commit to tiborsimko/reana-demo-cms-dimuon-mass-spectrum that referenced this pull request Jan 26, 2024
…b#15)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from 43c2aba to a128d47 Compare January 26, 2024 09:11
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one of the scripts needs to be amended

tiborsimko added a commit to tiborsimko/reana-demo-cms-dimuon-mass-spectrum that referenced this pull request Jan 29, 2024
Return properly the exit code status of shellcheck command when looping
through shell script files.
tiborsimko added a commit to tiborsimko/reana-demo-cms-dimuon-mass-spectrum that referenced this pull request Jan 29, 2024
…b#15)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from a128d47 to f2a6126 Compare January 29, 2024 16:55
Return properly the exit code status of shellcheck command when looping
through shell script files.
…b#15)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from f2a6126 to 9ef713b Compare January 29, 2024 17:04
@tiborsimko tiborsimko merged commit 9ef713b into reanahub:master Jan 29, 2024
2 checks passed
@tiborsimko tiborsimko deleted the ci-commitlint-shellcheck branch January 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants