utils: add permission error for getting workflows #216

DaanRosendal · 2023-12-15T11:04:38Z

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

Adds a table and an enum to the database. The `user_workflow` table makes it possible to verify whether a specific workflow has been shared with a user. The `accesstype` enum defines the different access types that can be granted to a user. For now, only `read` access is supported. Closes reanahub#206

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

Adds a table and an enum to the database. The `user_workflow` table makes it possible to verify whether a specific workflow has been shared with a user. The `accesstype` enum defines the different access types that can be granted to a user. For now, only `read` access is supported. Closes reanahub#206

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

Adds a table and an enum to the database. The `user_workflow` table makes it possible to verify whether a specific workflow has been shared with a user. The `accesstype` enum defines the different access types that can be granted to a user. For now, only `read` access is supported. Closes reanahub#206

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni · 2024-08-20T12:33:17Z

Latest version before rebase is a5726ff

Two things left:

Fixing utils: add include_shared_workflows parameter #212 (review) (maybe in a separate PR)
Should we revert the last commit that adds PermissionError? As far as I can tell, these exceptions are never caught anywhere else in the codebase. Furthermore, the PermissionError exception is OS exception, so it should not be used here (see https://docs.python.org/3/library/exceptions.html#PermissionError and https://docs.python.org/3/library/exceptions.html#OSError). It's breaking tests, too.

Adds a table and an enum to the database. The `user_workflow` table makes it possible to verify whether a specific workflow has been shared with a user. The `accesstype` enum defines the different access types that can be granted to a user. For now, only `read` access is supported. Closes reanahub#206

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

Adds a table and an enum to the database. The `user_workflow` table makes it possible to verify whether a specific workflow has been shared with a user. The `accesstype` enum defines the different access types that can be granted to a user. For now, only `read` access is supported. Closes reanahub#206

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni · 2024-08-29T10:33:24Z

Ready to be reviewed, squashed and merged

tiborsimko · 2024-09-04T16:03:34Z

Should we revert the last commit that adds PermissionError?

Agreed, I'll remove it for now before merging. (Kept local copy just in case.)

tiborsimko

Works nicely 👍 with

- r-client #692
- r-client-go #153
- r-ui #375
- r-server #658
- r-workflow-controller #552
- r-commons #429
- r-db #216

Removed the PermissionError commit and kept it locally.

codecov · 2024-09-04T16:14:29Z

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.76%. Comparing base (5b41246) to head (05a34ba).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
reana_db/utils.py	52.17%	11 Missing ⚠️
reana_db/models.py	94.11%	1 Missing ⚠️
reana_db/version.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   73.31%   73.76%   +0.45%     
==========================================
  Files           7        7              
  Lines         918      930      +12     
==========================================
+ Hits          673      686      +13     
+ Misses        245      244       -1

Files with missing lines	Coverage Δ
reana_db/models.py	`90.38% <94.11%> (+0.02%)`	⬆️
reana_db/version.py	`0.00% <0.00%> (ø)`
reana_db/utils.py	`75.94% <52.17%> (-0.35%)`	⬇️

... and 4 files with indirect coverage changes

DaanRosendal force-pushed the feature/shared-workflow-details branch from 142a09a to 91c557a Compare December 15, 2023 11:15

DaanRosendal force-pushed the feature/shared-workflow-details branch 5 times, most recently from 6c9ec6c to 0a7888a Compare March 14, 2024 13:20

DaanRosendal mentioned this pull request Mar 14, 2024

models: add workflow run sharing table #207

Closed

DaanRosendal force-pushed the feature/shared-workflow-details branch from 0a7888a to d0793d9 Compare March 14, 2024 13:54

DaanRosendal added a commit to DaanRosendal/reana-db that referenced this pull request Mar 14, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

d0793d9

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

DaanRosendal force-pushed the feature/shared-workflow-details branch from d0793d9 to a5726ff Compare March 18, 2024 10:48

DaanRosendal added a commit to DaanRosendal/reana-db that referenced this pull request Mar 18, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

a5726ff

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni pushed a commit to mdonadoni/reana-db that referenced this pull request Aug 9, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

e1179ab

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni pushed a commit to mdonadoni/reana-db that referenced this pull request Aug 9, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

922fb2b

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni pushed a commit to mdonadoni/reana-db that referenced this pull request Aug 9, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

d24677b

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni force-pushed the feature/shared-workflow-details branch from a5726ff to c5b70c7 Compare August 20, 2024 12:26

mdonadoni pushed a commit to DaanRosendal/reana-db that referenced this pull request Aug 20, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

c5b70c7

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni mentioned this pull request Aug 20, 2024

utils: add include_shared_workflows parameter #212

Closed

mdonadoni pushed a commit to DaanRosendal/reana-db that referenced this pull request Aug 20, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

bbbe345

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

mdonadoni force-pushed the feature/shared-workflow-details branch from c5b70c7 to bbbe345 Compare August 20, 2024 12:42

DaanRosendal added 2 commits August 29, 2024 11:32

feat(utils): add include_shared_workflows parameter (reanahub#216)

0f3c091

Adds new `include_shared_workflows` parameter to optionally retrieve unowned workflows that are shared with the user. Closes reanahub/reana-client#687

mdonadoni force-pushed the feature/shared-workflow-details branch from bbbe345 to 3b73082 Compare August 29, 2024 09:32

mdonadoni pushed a commit to DaanRosendal/reana-db that referenced this pull request Aug 29, 2024

feat(utils): add permission error for getting workflows (reanahub#216)

3b73082

Closes reanahub/reana-server#651, closes reanahub/reana-server#650

tiborsimko force-pushed the feature/shared-workflow-details branch from 3b73082 to 0f3c091 Compare September 4, 2024 16:00

chore(master): release 0.95.0a4

05a34ba

tiborsimko approved these changes Sep 4, 2024

View reviewed changes

tiborsimko merged commit 05a34ba into reanahub:master Sep 4, 2024
13 checks passed

mdonadoni mentioned this pull request Sep 19, 2024

refactor: make PermissionError return a 403 status code (forbidden) reanahub/reana-server#663

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

utils: add permission error for getting workflows #216

utils: add permission error for getting workflows #216

DaanRosendal commented Dec 15, 2023 •

edited

Loading

mdonadoni commented Aug 20, 2024 •

edited

Loading

mdonadoni commented Aug 29, 2024

tiborsimko commented Sep 4, 2024

tiborsimko left a comment

codecov bot commented Sep 4, 2024 •

edited

Loading

utils: add permission error for getting workflows #216

utils: add permission error for getting workflows #216

Conversation

DaanRosendal commented Dec 15, 2023 • edited Loading

mdonadoni commented Aug 20, 2024 • edited Loading

mdonadoni commented Aug 29, 2024

tiborsimko commented Sep 4, 2024

tiborsimko left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

DaanRosendal commented Dec 15, 2023 •

edited

Loading

mdonadoni commented Aug 20, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading