Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection: pessimistic disconnect handling #144

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

tiborsimko
Copy link
Member

@tiborsimko tiborsimko commented Oct 7, 2021

Closes #58. Closes #133.

Closes reanahub/reana#543.

@tiborsimko tiborsimko force-pushed the disconnect-handling branch from 3a36128 to 1da1f0b Compare October 7, 2021 09:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #144 (1da1f0b) into master (a9160bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files           7        7           
  Lines         679      679           
=======================================
  Hits          483      483           
  Misses        196      196           
Impacted Files Coverage Δ
reana_db/database.py 94.73% <100.00%> (ø)

Allows to configure parameters of DB connection pool for better
optimistic disconnect handling. Closes reanahub#58. Closes reanahub#133.
@tiborsimko tiborsimko force-pushed the disconnect-handling branch from 1da1f0b to e03c531 Compare October 7, 2021 12:46
Copy link
Member

@mvidalgarcia mvidalgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

$ reana-dev run-example
...
OK

@tiborsimko tiborsimko merged commit e03c531 into reanahub:master Oct 8, 2021
@tiborsimko tiborsimko deleted the disconnect-handling branch October 8, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: move to PostgreSQL 12 session: investigate non-closed sessions
3 participants