Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis-cache): add module (#469) #469

Closed

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Aug 20, 2024

Add redis-cache extra to be used in reana-workflow-controller API to cache workflow/job logs.

It will be possible to install it on demand as not all components need it. To use it, add annotation to a function, example in docs.

Also add myself to AUTHORS.md.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 34.70%. Comparing base (273b72d) to head (9a86a1b).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
reana_commons/redis_cache.py 0.00% 5 Missing ⚠️
reana_commons/config.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   34.84%   34.70%   -0.15%     
==========================================
  Files          26       27       +1     
  Lines        1650     1657       +7     
==========================================
  Hits          575      575              
- Misses       1075     1082       +7     
Files with missing lines Coverage Δ
reana_commons/config.py 0.00% <0.00%> (ø)
reana_commons/redis_cache.py 0.00% <0.00%> (ø)

@jlemesh
Copy link
Member Author

jlemesh commented Aug 20, 2024

Better put it to reana-workflow-controller.

@jlemesh jlemesh closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant