fix(config): remove hard-coded component host name domain (#457) #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
added a commit
to tiborsimko/reana-commons
that referenced
this pull request
May 6, 2024
Remove hard-coded infrastructure component host name domain "svc.local.cluster", since this assumption is not really necessary and made REANA not to work under some deployment scenarios, such as on SSL-RIVER. Closes reanahub#457
Removes hard-coded infrastructure component host name domain "svc.local.cluster", since this assumption is not really necessary and made REANA not to work under some deployment scenarios, such as on SSL-RIVER. Closes reanahub#457
mdonadoni
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hard-coded infrastructure component host name domain "svc.local.cluster", since this assumption is not really necessary and made REANA not to work under some deployment scenarios, such as on SSL-RIVER.
Closes #457