Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.9.4 #428

Merged
merged 1 commit into from
Nov 30, 2023
Merged

release: 0.9.4 #428

merged 1 commit into from
Nov 30, 2023

Conversation

mdonadoni
Copy link
Member

No description provided.

@mdonadoni mdonadoni mentioned this pull request Nov 29, 2023
30 tasks
--------------------------

- Changes the REANA specification schema to use the ``draft-07`` version of the JSON schema specification.
- Changes the REANA specification schema to use the ``draft-07`` version of the JSON Schema specification.
- Changes validation of REANA specification to expose functions for loading workflow input parameters and workflow specifications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: should we specify that we refer to CWL / Snakemake workflow input parameters?

Copy link
Member Author

@mdonadoni mdonadoni Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep it like this, the new function can be used also for other types of workflows (but it will not do anything in that case). This is also a quite-internal change, so I don't think there is a need to explain it further. Do you agree?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, good point!

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #428 (5fe5811) into master (120559a) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   37.66%   37.66%           
=======================================
  Files          26       26           
  Lines        1561     1561           
=======================================
  Hits          588      588           
  Misses        973      973           
Files Coverage Δ
reana_commons/version.py 0.00% <0.00%> (ø)

@mdonadoni mdonadoni merged commit 5fe5811 into reanahub:master Nov 30, 2023
16 checks passed
@mdonadoni mdonadoni deleted the release-0.9.4 branch January 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants